Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional configuration options to functional coverage / test task #201

Merged
merged 2 commits into from
Jan 19, 2017

Conversation

jayudey-wf
Copy link
Contributor

Issue

  • There were issues trying to set up the before and after commands needed for the functional tasks that wouldn't negatively impact other tasks.

Changes

Source:

  • Added the ability to specify tasks to be run exclusively before functional tasks.

Tests:

  • updated

Areas of Regression

  • functional coverage / testing
  • before and after commands for other tasks

Testing

  • CI
  • install into a project and ensure that newly added (and historical) functionality is working as expected

Code Review

@Workiva/web-platform-pp
@joewaters-wf

@evanweible-wf
Copy link
Contributor

+1

@sebastianmalysa-wf
Copy link

+1

1 similar comment
@maxwellpeterson-wf
Copy link
Member

+1

@joewaters-wf
Copy link

+10. Tested through https://github.com/joewaters-wf/w_context_menu/pull/1 WIP branch consuming these changes.

@evanweible-wf
Copy link
Contributor

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • Unit tests created/updated
  • All unit tests pass

Merging into master.

@evanweible-wf evanweible-wf merged commit 9ae523f into master Jan 19, 2017
@evanweible-wf evanweible-wf deleted the functional-coverage-settings branch October 8, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants