Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAP-1618 Skip files in .pub directories when formatting #213

Merged

Conversation

todbachman-wf
Copy link
Member

Problem:

When you specify a set of files to be excluded during formatting dart_dev walks the file structure and identifies each file that should be formatted. Currently it is picking up files in .pub folders. dartfmt skips those folders, so ddev format should too.

Solution:

Updated the format task to skip folders named .pub.

+10/QA:

  • CI build passes
  • Link dart_dev into a project with .pub directories and files excluded from formatting
  • Run ddev format on that project
  • Confirm dart files in.pub directories are not formatted

@evanweible-wf
Copy link
Contributor

+1

@maxwellpeterson-wf
Copy link
Member

+1

1 similar comment
@bencampbell-wf
Copy link
Contributor

+1

@bencampbell-wf
Copy link
Contributor

bencampbell-wf commented Feb 9, 2017

+10

Things Tested

  • CI build passes
  • Link dart_dev into a project with .pub directories and files excluded from formatting
  • Run ddev format on that project
  • Confirm dart files in.pub directories are not formatted

@jayudey-wf
Copy link
Contributor

@bencampbell-wf I will run the test locally and that should suffice to cover the failing tests, TravisCI has had some inconsistencies when running tests in the pass

@jayudey-wf
Copy link
Contributor

test pass locally, will let that constitute as a passing result for this CI process

@jayudey-wf
Copy link
Contributor

jayudey-wf commented Feb 9, 2017

QA: +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • performed and documented by Ben
  • Unit test created/updated
  • All unit tests pass (passing locally)

Merging into master.

@jayudey-wf jayudey-wf merged commit cd78dba into Workiva:master Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants