Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dependency_validator #257

Merged
merged 1 commit into from
May 1, 2018
Merged

Use dependency_validator #257

merged 1 commit into from
May 1, 2018

Conversation

aaronlademann-wf
Copy link
Contributor

Pretty self-explanatory.

@Workiva/app-frameworks

@aaronlademann-wf aaronlademann-wf requested a review from a team as a code owner April 30, 2018 22:08
@codecov-io
Copy link

Codecov Report

Merging #257 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   22.98%   22.98%           
=======================================
  Files           7        7           
  Lines         161      161           
=======================================
  Hits           37       37           
  Misses        124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ed5a7...ff7edef. Read the comment docs.

@jayudey-wf
Copy link
Contributor

+1

@jayudey-wf
Copy link
Contributor

jayudey-wf commented May 1, 2018

QA +1

  • Testing instruction (derived from code change type)
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • passing CI
  • Security review (if required)
  • Unit tests created/updated (n/a CI update)
  • All unit tests pass
  • Rosie has run and reports properly the release the ticket will be included in

Merging into master.

@jayudey-wf
Copy link
Contributor

@Workiva/release-management-pp

@rmconsole-wf rmconsole-wf merged commit 7eee6da into master May 1, 2018
@evanweible-wf evanweible-wf deleted the dependency_validator branch October 8, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants