Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically extend the Dartium expiration date for test/coverage tasks #266

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

greglittlefield-wf
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf commented Jul 10, 2018

Problem

Dartium has hit its built-in expiration date, and cannot run Dart code properly unless the date is overridden using the DARTIUM_EXPIRATION_TIME environment variable.

dart-lang/sdk#33580

This causes tests and coverage to timeout inexplicably when running content-shell, and only with a popup warning when running in Dartium.

Solution

Automatically set this flag in relevant processes launched by dart_dev to work around this issue and prevent frustrating content-shell failures.

Testing:

  • Run ddev test/ddev coverage in a terminal where DARTIUM_EXPIRATION_TIME is unset, and verify that tests pass

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@codecov-io
Copy link

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   22.98%   22.98%           
=======================================
  Files           7        7           
  Lines         161      161           
=======================================
  Hits           37       37           
  Misses        124      124
Impacted Files Coverage Δ
lib/src/util.dart 39.47% <ø> (ø) ⬆️
lib/src/task_process.dart 53.65% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eee6da...e9a9ce6. Read the comment docs.

@jayudey-wf
Copy link
Contributor

jayudey-wf commented Jul 10, 2018

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • verified that w/ this change content_shell was able to load and run tests and then w/o this change content_shell just hung regarding the test and coverage task
  • Security review (if required)
  • Unit tests created/updated (n/a)
  • All unit tests pass
  • Rosie has run and reports properly the release the ticket will be included in
  • Areas of regression noted

Merging into master.

Copy link
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 reminds me of
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants