Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up build #273

Merged
merged 2 commits into from
Sep 7, 2018
Merged

clean up build #273

merged 2 commits into from
Sep 7, 2018

Conversation

josephswanson-wf
Copy link
Contributor

  • use dart image
  • remove unneeded args and echo
  • delete smithy.yaml (it's time)

@Workiva/app-frameworks @bradbenjamin-wf @jeffhall-wk

@josephswanson-wf josephswanson-wf requested a review from a team as a code owner September 7, 2018 18:28
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@codecov-io
Copy link

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   21.76%   21.76%           
=======================================
  Files           8        8           
  Lines         170      170           
=======================================
  Hits           37       37           
  Misses        133      133

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33cbd24...32866ce. Read the comment docs.

@evanweible-wf
Copy link
Contributor

QA +1

  • CI passes

@Workiva/release-management-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants