Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-2776 Deprecate SaucePlatform and SaucePlatform constants #277

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

evanweible-wf
Copy link
Contributor

Description

There are a few additional pieces related to the saucelabs task that need to be deprecated in order for us to fully remove it in 2.0.0.

Changes

  • Deprecate SaucePlatform and the constant instances of SaucePlatform.
  • Updated CHANGELOG.md for this release and last release

Testing

  • CI passes

Code Review

@Workiva/app-frameworks

@evanweible-wf evanweible-wf requested a review from a team as a code owner October 9, 2018 17:15
@rmconsole3-wf rmconsole3-wf changed the title Deprecate SaucePlatform and SaucePlatform constants AF-2776 Deprecate SaucePlatform and SaucePlatform constants Oct 9, 2018
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@sebastianmalysa-wf
Copy link

QA +1

  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • CI passes
  • All unit tests pass

@Workiva/release-management-pp

@rm-astro-wf rm-astro-wf merged commit 5b7783b into master Oct 9, 2018
@evanweible-wf evanweible-wf deleted the deprecate_SaucePlatform branch October 9, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants