Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AF-3801 fix reporter runtime error in Dart 2.1.0 #287

Merged
merged 3 commits into from
Jan 14, 2019
Merged

AF-3801 fix reporter runtime error in Dart 2.1.0 #287

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3b36d0
fix reporter runtime error in Dart 2.1.0
robrbecker Jan 11, 2019
b10daba
Don't allow nulls by:
robrbecker Jan 11, 2019
9732d37
prevent people from setting quiet,color to null
robrbecker Jan 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/src/reporter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ class Reporter {
color && message.isNotEmpty ? pen(message) : message;

void _log(IOSink sink, String message, {bool shout: false}) {
if (quiet && !shout) return;
// This may look like a strange conditional, but please leave it.
// Somehow when using the tearoff `reporter.log` the `quiet` variable
// is null, which causes a runtime error when running tests in Dart 2.1.0
if (quiet == true && shout != true) return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be that Reporter isn't getting passed both arguments during intiialization?

dart_dev/lib/src/reporter.dart

Line 22 in 7eee6da

Reporter reporter = new Reporter();

Based on the existing code,

dart_dev/lib/src/reporter.dart

Lines 30 to 35 in a3b36d0

bool color = true;
bool quiet = false;
Reporter({bool this.color, bool this.quiet});
String colorBlue(String message) => _color(_blue, message);

, I would expect new Reporter() to have both fields be null.

I feel like it should just be:

bool color;
bool quiet;

Reporter({bool this.color = true, bool this.quiet = false});

Could it be that it's only showing up in testing because this is being run in checked mode?

sink.writeln(message);
}
}