-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test config option to delete conflicting outputs by default in Dart 2 #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
smaifullerton-wk
changed the title
Delete conflicting outputs by default
Add test config option to delete conflicting outputs by default in Dart 2
Jun 11, 2019
corwinsheahan-wf
approved these changes
Jun 11, 2019
…exits with 1 when build fails
…l-outputs-by-default
…dart_dev into delete-confl-outputs-by-default
corwinsheahan-wf
approved these changes
Jun 11, 2019
+10 Testing Performed
|
evanweible-wf
approved these changes
Jun 11, 2019
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Dart 1 is still the default modus operandi for devs, the Dart 2 build will prompt the user to delete conflicting outputs in repos with generated files. Currently, it's not possible to use a ddev task to run tests and delete these conflicting outputs.
This PR add a test config option to delete the conflicting outputs by default so we can turn on this option in highly trafficked repos and allow devs to use
ddev test
to run tests in Dart 2 without worrying about the underlying build stuff going on.QA +1 Instructions
config.test.deleteConflictingOutputs = true
in dev.dart of this repoddev test
successfully, and that --delete-conflicting-outputs is added to the flags passed to the initial build