Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test config option to delete conflicting outputs by default in Dart 2 #300

Merged
merged 8 commits into from
Jun 11, 2019

Conversation

smaifullerton-wk
Copy link
Contributor

@smaifullerton-wk smaifullerton-wk commented Jun 11, 2019

While Dart 1 is still the default modus operandi for devs, the Dart 2 build will prompt the user to delete conflicting outputs in repos with generated files. Currently, it's not possible to use a ddev task to run tests and delete these conflicting outputs.

This PR add a test config option to delete the conflicting outputs by default so we can turn on this option in highly trafficked repos and allow devs to use ddev test to run tests in Dart 2 without worrying about the underlying build stuff going on.

QA +1 Instructions

  • CI passes
  • Use dart_dev dep override in a repo that has generated files from a source_gen builder
  • Set config.test.deleteConflictingOutputs = true in dev.dart of this repo
  • Switch to Dart 2
  • Confirm that you can run ddev test successfully, and that --delete-conflicting-outputs is added to the flags passed to the initial build

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@smaifullerton-wk smaifullerton-wk changed the title Delete conflicting outputs by default Add test config option to delete conflicting outputs by default in Dart 2 Jun 11, 2019
@todbachman-wf
Copy link
Member

todbachman-wf commented Jun 11, 2019

+10

Testing Performed

  • CI (mostly) passes
  • Use dart_dev dep override in a repo that has generated files from a source_gen builder
  • Set config.test.deleteConflictingOutputs = true in dev.dart of this repo
  • Switch to Dart 2
  • Confirm that you can run ddev test successfully, and that --delete-conflicting-outputs is added to the flags passed to the initial build

@evanweible-wf
Copy link
Contributor

@Workiva/release-management-p

@rmconsole7-wk rmconsole7-wk merged commit cf3291e into master Jun 11, 2019
@rmconsole7-wk rmconsole7-wk deleted the delete-confl-outputs-by-default branch June 11, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants