Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ./ before sending test path to runner generation with hack-fast-builds flag #326

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

corwinsheahan-wf
Copy link
Contributor

Motivation

The --hack-fast-builds functionality doesn't gracefully handle test paths which start with ./.

Changes

Check the path and remove the preceding ./ if it exists before sending it to the runner generation.

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link

@willdrach-wk willdrach-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corwinsheahan-wf
Copy link
Contributor Author

QA +1

  • Travis failure is a known issue that will be fixed in dart_dev v3
  • Can now use the hack-fast-builds flag with ./ and non-./ prefixed test paths
    Merging into master.
    @Workiva/release-management-p

@rmconsole2-wf rmconsole2-wf merged commit 68169c0 into master Oct 24, 2019
@rmconsole2-wf rmconsole2-wf deleted the handle_dot_in_test_path_for_hfb branch October 24, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants