-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widen Dependency Ranges Blocking Dart 2.13 #352
Merged
rmconsole5-wk
merged 6 commits into
master
from
campaign/client_platform/dart-213-dependency-range-widen
Jul 21, 2021
Merged
Widen Dependency Ranges Blocking Dart 2.13 #352
rmconsole5-wk
merged 6 commits into
master
from
campaign/client_platform/dart-213-dependency-range-widen
Jul 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
aaronlademann-wf
force-pushed
the
campaign/client_platform/dart-213-dependency-range-widen
branch
from
July 21, 2021 16:55
271b428
to
4f95d7d
Compare
aaronlademann-wf
force-pushed
the
campaign/client_platform/dart-213-dependency-range-widen
branch
from
July 21, 2021 17:01
a1fd38f
to
f0c20dd
Compare
+ So that we don't have to update all the test fixtures
evanweible-wf
approved these changes
Jul 21, 2021
QA +1
@Workiva/release-management-p |
rmconsole-wf
added
Merge Requirements Met
RM Ready
and removed
Merge Requirements Unmet
labels
Jul 21, 2021
rmconsole-wf
approved these changes
Jul 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
rmconsole5-wk
deleted the
campaign/client_platform/dart-213-dependency-range-widen
branch
July 21, 2021 20:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order for projects to be compatible with Dart 2.13, there are dependencies that need to have their ranges widened.
For a list of dependencies expected to be changed, see the dependencies section of the Dart 2.12+ wiki page.
Another necessary change is the removal of
build_vm_compilers
. If this is the case, additional clean up may need to be done, such as removing the associated config frombuild.yaml
or updating how tests are run. A member of Client Platform will be following up with PRs that have CI failures to resolve any issues or perform necessary clean up.For any questions or concerns, don't hesitate to reach us in the #support-client-plat Slack channel!
Changes
build_vm_compilers
if it was presentQA
Created by Sourcegraph batch change
Workiva/dart_213_dependency_range_widen
.