Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEDX-13: Dart 2.18 lints & formatting #401

Merged
merged 10 commits into from
Feb 14, 2023
Merged

FEDX-13: Dart 2.18 lints & formatting #401

merged 10 commits into from
Feb 14, 2023

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Feb 14, 2023 •
edited by bender-wk
Loading

FEDX-13

Issue Status

  • Address new lints on 2.18
  • Run formatter on 2.18
  • Replace deprecated pedantic package with lints package
  • Tweaks to CI

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@evanweible-wf evanweible-wf requested a review from a team February 14, 2023 15:38
@rmconsole5-wk rmconsole5-wk changed the title Dart 2.18 lints & formatting FEDX-13 Dart 2.18 lints & formatting Feb 14, 2023
@bender-wk bender-wk changed the title FEDX-13 Dart 2.18 lints & formatting FEDX-13: Dart 2.18 lints & formatting Feb 14, 2023
robbecker-wf
robbecker-wf reviewed Feb 14, 2023
View reviewed changes
pubspec.yaml
@@ -23,6 +23,7 @@ dependencies:

dev_dependencies:
dependency_validator: ^3.0.0
lints: ^1.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can pedantic be removed as a dependency now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not quite :( We use unawaited and that wasn't added to dart:async until a version of Dart after 2.11, so we'd have to raise our minimum. I plan to drop it after the NNBD migration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, sounds great.

@evanweible-wf
Copy link
Contributor Author

QA +1 CI passes
@Workiva/release-management-p

rmconsole-wf
rmconsole-wf approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit b29b823 into master Feb 14, 2023
@rm-astro-wf rm-astro-wf deleted the dart2.18-lints branch February 14, 2023 16:22
@rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewnitschke-wk matthewnitschke-wk matthewnitschke-wk approved these changes

@robbecker-wf robbecker-wf robbecker-wf approved these changes

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready semver: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@evanweible-wf @aviary2-wf @rmconsole-wf @robbecker-wf @matthewnitschke-wk @rm-astro-wf