Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDX-518 Now that dart_dev itself is null-safe, it should be able to generate a null-safe run script #420

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

evanweible-wf
Copy link
Contributor

Problem

When we migrated this package to null-safe, we missed some logic in our run script generation that would include a Dart language comment to set the language version to 2.9 by default. This prevents the null-safe dart_dev from being able to run on Dart 3 where null-safety is required.

Solution

Remove this logic as it's no longer needed. We'll still copy over a language comment from tool/dart_dev/config.dart if one exists, otherwise we omit it which will allow dart_dev to run on Dart 3.

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rm-astro-wf rm-astro-wf changed the title Now that dart_dev itself is null-safe, it should be able to generate a null-safe run script FEDX-518 Now that dart_dev itself is null-safe, it should be able to generate a null-safe run script Nov 9, 2023
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes look good
  • Existing functional tests pass, that verify that dart_dev works as expected when packages have opted into null safety
  • Manually tested in a package that is not yet opted into null safety and has a custom config, and dart_dev commands work as expected

+10

@evanweible-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit 8903a9c into master Nov 9, 2023
7 checks passed
@rm-astro-wf rm-astro-wf deleted the generate-null-safe-run-script branch November 9, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants