FEDX-518 Now that dart_dev itself is null-safe, it should be able to generate a null-safe run script #420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When we migrated this package to null-safe, we missed some logic in our run script generation that would include a Dart language comment to set the language version to 2.9 by default. This prevents the null-safe dart_dev from being able to run on Dart 3 where null-safety is required.
Solution
Remove this logic as it's no longer needed. We'll still copy over a language comment from
tool/dart_dev/config.dart
if one exists, otherwise we omit it which will allow dart_dev to run on Dart 3.