Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format_tool: optimization pass #424

Merged
merged 4 commits into from
Feb 21, 2024
Merged

format_tool: optimization pass #424

merged 4 commits into from
Feb 21, 2024

Commits on Feb 20, 2024

  1. format_tool: optimization pass

    We can save a lot (90%) of execution time on some repos with two
    changes:
    
     - Not recursing into directories that are a priori excluded from the
       formatter's list (e.g., hidden directories like .git). Note that this
       means we no longer build and log a comprehensive list of excluded
       files. I think it's worth it to run so much faster.
    
     - Removing the collapseDirectories feature, to be replaced with
       batch parallel invocations. Computing the collapsible directories
       was some kind of superlinear deduplication. This could maybe be
       optimized in a way that would allow it to remain, but it seems it was
       intended as a stopgap solution for argv limitations in the first
       place.
    alexandercampbell-wk committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    e69cf3b View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Configuration menu
    Copy the full SHA
    0f178fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6537959 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1b45fb6 View commit details
    Browse the repository at this point in the history