Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed validate publish check #15

Closed
wants to merge 2 commits into from

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Aug 17, 2024

The checks/validate job that was added in #13 , just simply did not work: Workiva/scip-dart#136 (it was still skipped: https://github.com/Workiva/scip-dart/actions/runs/10321235192/job/28573706991?pr=136)

Because of this, the current suggestion will be to just implement a dart pub publish --dry-run call within each oss dart repo, based on the pre-existing publish setup.

This will probably look something like:

name: Publish PR

on:
  pull_request:

jobs:
  validate-publish:
    runs-on: ubuntu-latest
    if: if: ${{ startsWith(github.ref, 'refs/heads/<your release branch prefix>/') }}
    steps:
       - uses: dart-lang/setup-dart@v1
          with:
            sdk: 2.19.0
      - run: dart pub publish --dry-run

If we come up with more ideas to add to a "on publish" or publish validation, we can always re-add this concept, maybe as a re-usable workflow? or make the checks workflow more extendable?

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants