-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEA-4583: Support packages that don't utilize dart_dev #21
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I messaged Nitschke on Slack but will post here for visibility:
- I think we could simplify the test-unit workflow a bit by removing a couple of inputs that shouldn't be needed.
- If the overhead for detecting ddev and/or build_runner + build_test is too much, we could consider creating separate reusable workflows for each use case:
dart test
,build_runner test
, andddev test
.
QA +1
🚀 @Workiva/release-management-p 🚢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
FEA-4583
Its pretty common for our oss libs to not implement dart_dev, and we dont necessarily want to make that a requirement
This pr allows running the
checks
workflow without dart_dev so it can pass on repos like Workiva/webdev_proxyNote,
test-unit
has been left alone, this still requires dart_dev. I haven't decided on if its best to try and figure out how to make that optional? or just have oss repos rundart test
manually