Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA-4583: Support packages that don't utilize dart_dev #21

Merged
merged 17 commits into from
Sep 4, 2024

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Aug 28, 2024

FEA-4583

Issue Status

Its pretty common for our oss libs to not implement dart_dev, and we dont necessarily want to make that a requirement

This pr allows running the checks workflow without dart_dev so it can pass on repos like Workiva/webdev_proxy

Note, test-unit has been left alone, this still requires dart_dev. I haven't decided on if its best to try and figure out how to make that optional? or just have oss repos run dart test manually

@matthewnitschke-wk matthewnitschke-wk requested a review from a team as a code owner August 28, 2024 20:50
@bender-wk bender-wk changed the title dart_dev-less checks action FEA-4583: dart_dev-less checks action Aug 28, 2024
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk marked this pull request as draft August 28, 2024 21:58
Copy link

@evanweible-wf evanweible-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I messaged Nitschke on Slack but will post here for visibility:

  • I think we could simplify the test-unit workflow a bit by removing a couple of inputs that shouldn't be needed.
  • If the overhead for detecting ddev and/or build_runner + build_test is too much, we could consider creating separate reusable workflows for each use case: dart test, build_runner test, and ddev test.

.github/workflows/test-unit.yaml Show resolved Hide resolved
@matthewnitschke-wk matthewnitschke-wk changed the title FEA-4583: dart_dev-less checks action FEA-4583: Support packages that don't utilize dart_dev Aug 30, 2024
@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review August 30, 2024 23:59
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

  • CI does indeed pass

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit bd229c1 into master Sep 4, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants