Skip to content

Commit

Permalink
O11Y-1665: Stub out remaining interface methods in opentelemetry-dart
Browse files Browse the repository at this point in the history
 - Exposing API to set Span name.
  • Loading branch information
Michael Yeager committed Apr 13, 2022
1 parent 091b82f commit 80f223e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions lib/src/api/trace/nonrecording_span.dart
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ class NonRecordingSpan implements api.Span {
@override
String get name => 'NON_RECORDING';

@override
set name(String _name) {}

@override
bool get isRecording => false;

Expand Down
2 changes: 1 addition & 1 deletion lib/src/api/trace/span.dart
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ abstract class Span {
api.SpanId get parentSpanId;

/// The name of the span.
String get name;
String name;

/// Whether this Span is recording information like events with the
/// addEvent operation, status with setStatus, etc.
Expand Down

0 comments on commit 80f223e

Please sign in to comment.