Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial branch #1

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Initial branch #1

merged 2 commits into from
Jul 22, 2021

Conversation

tylersnavely-wf
Copy link
Contributor

@evanweible-wf had started this effort many months ago, and we want to pick it up and push it forward with dedicated resources.
Looking at where he left off, the code is in a pretty good state; much better than starting from scratch. The work is based on the OpenTelemetry Specification for language implementation.

This PR just copies all of Evan's work as a base for us to work off of. The first commit was authored by him, and then I added some new repo boilerplate stuff in the second.

@rmconsole-wf
Copy link

rmconsole-wf commented Jul 21, 2021

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s): None found in title
Code Review(s): #1
Release Image Tags:

Reviewers: blakeroberts-wk, tylersnavely-wf

Additional Information

Watchlist Notifications: None

	When this pull is merged I will add it to the following release:
	Version: opentelemetry-dart 0.1.0
	Release Ticket(s): None


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Thursday, July 22 11:26 AM CST

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@@ -0,0 +1,5 @@
import 'package:'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should delete everything vm. I think that's outside the scope of this project and I don't want to support it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure. I was planning to have us only keep the opentelemetry_api and opentelemetry_sdk sections, and move the opentelemetry_context into them. I think we can clear this up in a follow up PR. My intentions were to just include the original work so we could have a starting place for discussions and a place where we can start working async.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry, late to the party 😄) totally agree on focusing on the browser use case for now, but it may be worth keeping in mind along the way whether there's anything in the implementations that requires browser APIs. If we can instead write it in a platform-agnostic way, then it becomes usable from VM, web, and flutter, which would be nice.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely. I'd hope we wouldn't have any code that depends on browser specific APIs. If that becomes the case, it should be easy enough to label the overarching interface implementation as browser specific and leave room for a vm implementation

@tylersnavely-wf
Copy link
Contributor Author

QA +1

@tylersnavely-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants