Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O11Y-994: OTEL Dart: Implement Tracer Provider API #10

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

michaelyeager-wf
Copy link
Contributor

Notes

This PR adds the following:

  • [Commit 1] The TracerProvider API, which includes the following:
    • TracerProvider, which centralizes state, settings, and defaults for Tracers created.
    • Sampler, which determines whether a Span should be sampled and sent for collection.
    • SamplingResult, which is the decision made by a Sampler regarding a Span.
    • InstrumentationLibrary, which represents versioning metadata within applications which use multiple implementations of OpenTelemetry.
    • AlwaysOnSampler, a default sampler which always samples.
    • AlwaysOffSampler, a default sampler which never samples.
  • [Commit 2] A format make target which formats all library code and tests. This commit includes the results of running the make target.
  • [Commit 3] A make target to inject version information into InstrumentationLibrary (see above) so that it stays up-to-date.

Reviewers

@tylersnavely-wf
@Workiva/product-new-relic

@michaelyeager-wf michaelyeager-wf requested a review from a team as a code owner September 7, 2021 22:23
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole-wf
Copy link

rmconsole-wf commented Sep 7, 2021

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s):

Code Review(s): #10
Release Image Tags:

Reviewers: tylersnavely-wf

Additional Information

Watchlist Notifications: None

	When this pull is merged I will add it to the following release:
	Version: opentelemetry-dart 0.0.3
	Release Ticket(s): O11Y-1065


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Wednesday, September 29 02:22 PM CST

@michaelyeager-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit 4821f21 into Workiva:master Sep 29, 2021
@rm-astro-wf rm-astro-wf deleted the myeager-wf/O11Y-994 branch September 29, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants