O11Y-2859: Disable code coverage comments on pull requests #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Public API ChangesNo changes to the public API found for commit 3a5f4f5 Showing results for 3a5f4f5
Last edited UTC May 02 at 20:52:49 |
|
Coverage after merging O11Y-2859 into master will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
dustinlessard-wf
commented
May 2, 2023
| @@ -8,6 +8,9 @@ on: | |||
| pull_request: | |||
| branches: | |||
| - '*' | |||
| concurrency: | |||
| group: opentelemetry-coverage-${{ github.ref }}-1 | |||
There was a problem hiding this comment.
This ensures that when pushing commits during a short period, only the last commit pushed receives a full CI run. Prior CI runs will be cancelled.
dustinlessard-wf
changed the title
blakeroberts-wk
approved these changes
May 2, 2023
evanweible-wf
approved these changes
May 2, 2023
Comment on lines
-19
to
-25
| strategy: | ||
| matrix: | ||
| # Don't run on newer SDKs until we're able to get on analyzer 1.x, | ||
| # since our current analyzer version range results in build failures | ||
| # when analysis hits the `<<<` operator. | ||
| # sdk: [ 2.13.4, stable, dev ] | ||
| sdk: [ 2.13.4 ] |
There was a problem hiding this comment.
Note to selves, we should get back to the point where we can run CI on 2.18 as well as the latest 2.x and eventually 3.0
|
QA +1 |
rmconsole-wf
added
RM Ready
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The CI for this repo depends on the Github token when posting code coverage info to the pull request. When 3rd parties propose changes, the CI fails because the Github token is not available to those 3rd parties.
Fixes # (issue)
Short description of the change
How Has This Been Tested?
The CI on this pr can confirm these changes will not disrupt the CI workflow.