Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency for meta to pubspec.yaml #111

Merged
merged 2 commits into from
May 25, 2023
Merged

Conversation

michaelyeager-wf
Copy link
Contributor

Which problem is this PR solving?

Attempting to package this library with dart pub publish results in the following message:

Package validation found the following errors:
* line 4, column 1 of lib/src/experimental_api.dart: This package does not have meta in the `dependencies` section of `pubspec.yaml`.
    ╷
  4 │ import 'package:meta/meta.dart';
    │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
* line 4, column 1 of lib/src/experimental_sdk.dart: This package does not have meta in the `dependencies` section of `pubspec.yaml`.
    ╷
  4 │ import 'package:meta/meta.dart';
    │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵

...which prevent this library from releasing.

Fixes # (issue)

meta has been added to pubspec.yaml at version 1.9.1 (latest).

How Has This Been Tested?

  1. Verified the presence of the described issue without changes to pubspec.yaml.
  2. Verified the absence of the described issue following changes to pubspec.yaml.

Checklist:

  • Unit tests have been added
  • Documentation has been updated

@michaelyeager-wf
Copy link
Contributor Author

  • Verified the described error without changes to pubspec.yaml.
  • Verified error no longer occurs following changes to pubspec.yaml.

QA +1

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@semveraudit-wf
Copy link

semveraudit-wf commented May 25, 2023

Public API Changes

No changes to the public API found for commit 0803de4

Showing results for 0803de4

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.2
Browse public API.

Last edited UTC May 25 at 19:57:38

@michaelyeager-wf
Copy link
Contributor Author

Verified error no longer occurs following changes to pubspec.yaml.

QA +1

@michaelyeager-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit 2505e88 into master May 25, 2023
@rm-astro-wf rm-astro-wf deleted the add-meta-dependency branch May 25, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants