O11Y-3736: opentelemetry-dart: Deprecate MeterSharedState #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelyeager-wf
requested review from
evanweible-wf,
dustinlessard-wf and
a team
as code owners
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
|
Since we haven't implemented MetricExporters, etc yet we won't be able to use a test application to verify these changes. The existing unit tests should be sufficient, since they verify that MeterProviders can be created and properly manage state. QA +1 |
- Mark Meter protected.
keruitan-wk
approved these changes
Nov 28, 2023
blakeroberts-wk
approved these changes
Nov 28, 2023
|
Unit tests pass following this change. QA +1 |
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
MeterSharedState currently encapsulates actions which should be the responsibility of MeterProvider.
Short description of the change
In order to improve adherence to the OpenTelemetry specification, this PR moves state management responsibility for meters into
MeterProviderand removes shared state classes.How Has This Been Tested?