Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trace exporter to include trace state and drop counts #184

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

blakeroberts-wk
Copy link
Contributor

@blakeroberts-wk blakeroberts-wk commented Aug 20, 2024

Which problem is this PR solving?

The exporter does not include:

  • trace state on the span
  • dropped span attributes count
  • dropped span links count
  • dropped link attributes count

Fixes N/A

Short description of the change

The exporter will export:

  • trace state on the span
  • dropped span attributes count
  • dropped span links count
  • dropped link attributes count

How Has This Been Tested?

Pulled changes into a deployed app and spans were successfully exported and retrieved from a trace backend.

Checklist:

  • Unit tests have been added
  • Documentation has been updated

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@blakeroberts-wk
Copy link
Contributor Author

QA +1 deployed changes to web app and successfully exported and retrieved spans from backend.

@blakeroberts-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit a43cb35 into master Aug 22, 2024
4 checks passed
@rmconsole7-wk rmconsole7-wk deleted the export-trace-state-and-drop-counts branch August 22, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants