Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API For Registering Global Instance #24

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

michaelyeager-wf
Copy link
Contributor

Notes

This PR adds API for registering a global instance of OpenTelemetry so that wo11y-dart can perform set-up operations and so that applications and middleware can both use the configured TracerProvider.

This PR also relocates API classes into the API package.

Reviewers

@Workiva/product-new-relic

@rmconsole-wf
Copy link

rmconsole-wf commented Nov 9, 2021

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s): None found in title
Code Review(s): #24
Release Image Tags:

Reviewers: michaelyeager-wf, blakeroberts-wk

Additional Information

Watchlist Notifications: None
Pull Requests included in release:

	When this pull is merged I will add it to the following release:
	Version: opentelemetry-dart 0.1.9
	Release Ticket(s): O11Y-1258

	This pull is considered the release of opentelemetry-dart 0.1.9 
	The options defined for this repo will be carried out


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Thursday, November 11 09:58 AM CST

@michaelyeager-wf
Copy link
Contributor Author

Used the test app to test this in concert with upcoming changes to wo11y-dart and messaging-sdk: https://onenr.io/0Z2R54P3Vwb

QA +1

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@blakeroberts-wk
Copy link
Contributor

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit 6fbdadc into Workiva:master Nov 11, 2021
@rmconsole7-wk rmconsole7-wk deleted the myeager-wf/otel-global branch November 11, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants