Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose StatusCode API #27

Merged

Conversation

michaelyeager-wf
Copy link
Contributor

Notes

This PR exposes StatusCode so that the status of Spans can be set:

span.setStatus(StatusCode.error)

Reviewers

@Workiva/product-new-relic

@rmconsole-wf
Copy link

rmconsole-wf commented Nov 15, 2021

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s): None found in title
Code Review(s): #27
Release Image Tags:

Reviewers: blakeroberts-wk, keruitan-wk

Additional Information

Watchlist Notifications: None
Pull Requests included in release:

	When this pull is merged I will add it to the following release:
	Version: opentelemetry-dart 0.1.12
	Release Ticket(s): O11Y-1301

	This pull is considered the release of opentelemetry-dart 0.1.12 
	The options defined for this repo will be carried out


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Tuesday, November 16 09:50 AM CST

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@michaelyeager-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit 3f2c1f1 into Workiva:master Nov 16, 2021
@rmconsole6-wk rmconsole6-wk deleted the myeager-wf/expose-statuscode branch November 16, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants