Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run semver report as part of CI #40

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Run semver report as part of CI #40

merged 3 commits into from
Feb 24, 2022

Conversation

jayudey-wf
Copy link
Contributor

@jayudey-wf jayudey-wf commented Feb 24, 2022

As part of the CI process let's run the semver tooling that we have in place.

NOTE, this process will need to be re-visited once this is OSS'd

@rmconsole-wf
Copy link

rmconsole-wf commented Feb 24, 2022

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s): None found in title
Code Review(s): #40
Release Image Tags:

Reviewers: blakeroberts-wk

Additional Information

Watchlist Notifications: None
Pull Requests included in release:

	When this pull is merged I will add it to the following release:
	Current version: opentelemetry-dart 0.1.21
	Version after merge: opentelemetry-dart 0.1.21
	Release Ticket(s): O11Y-1575

	This pull is considered a release pull
	The options defined for this repo will be carried out


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Thursday, February 24 03:17 PM CST

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@semveraudit-wf
Copy link

semveraudit-wf commented Feb 24, 2022

Public API Changes

No changes to the public API found for commit c7b7250

Showing results for c7b7250

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.2
Browse public API.

Last edited UTC Feb 24 at 21:07:03

@jayudey-wf jayudey-wf changed the title Try running semver report Run semver report as part of CI Feb 24, 2022
@jayudey-wf jayudey-wf marked this pull request as ready for review February 24, 2022 21:10
@jayudey-wf jayudey-wf requested a review from a team as a code owner February 24, 2022 21:10
Copy link
Contributor

@blakeroberts-wk blakeroberts-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Question: do we have past experience running this tool on an open source project? Or has the solution in the past been to simply turn it off/not use it?

@jayudey-wf
Copy link
Contributor Author

it's looking like we'd just turn it off from the few OSS projects i've looked at

@blakeroberts-wk
Copy link
Contributor

@Workiva/release-management-p

@rmconsole3-wf rmconsole3-wf merged commit c769e05 into master Feb 24, 2022
Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf deleted the semver-report branch February 24, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants