O11Y-1749: OpenTelemetry Dart: Complete Implementation of SpanKind

[michaelyeager-wf]

Notes

This PR adds the following:

• CollectorExporter now exports SpanKind information.
• Parameter spanIsRemote has been removed from Sampler. It is not present in the OpenTelemetry specification and was unused.

Reviewers

@Workiva/product-new-relic

[rmconsole-wf]

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s):

• O11Y-1749 | remove

Code Review(s): #50
Release Image Tags:

Reviewers: michaelyeager-wf, blakeroberts-wk

Additional Information

Watchlist Notifications: None
Pull Requests included in release:

	When this pull is merged I will add it to the following release:
	Current version: opentelemetry-dart 0.8.1
	Version after merge: opentelemetry-dart 0.9.0
	Release Ticket(s): O11Y-1769

	This pull is considered a release pull
	The options defined for this repo will be carried out

---

Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Friday, April 29 09:28 AM CST

[michaelyeager-wf]

Verified that kind information is properly reported for Spans emitted by our Dart test application and Messaging SDK middleware: https://onenr.io/0VjYDqXm3R0

QA +1

[aviary2-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[semveraudit-wf]

Public API Changes

Recommendation: ‼️ Major version bump (fyi @Workiva/semver-audit-group )

@@ line 6: package:opentelemetry/src/sdk/trace/sampling/sampler.dart @@
abstract class Sampler
-     SamplingResult shouldSample(Context context, TraceId traceId, String spanName, SpanKind spanKind, bool spanIsRemote, List<Attribute> spanAttributes, List<SpanLink> spanLinks)
+     SamplingResult shouldSample(Context context, TraceId traceId, String spanName, SpanKind spanKind, List<Attribute> spanAttributes, List<SpanLink> spanLinks)
//    `type` of `spanIsRemote` has changed.
//    Changing a parameter signature is a major change.

@@ line 4: package:opentelemetry/src/sdk/trace/sampling/always_on_sampler.dart @@
class AlwaysOnSampler implements Sampler
-     SamplingResult shouldSample(Context context, TraceId traceId, String spanName, SpanKind spanKind, bool spanIsRemote, List<Attribute> spanAttributes, List<SpanLink> spanLinks)
+     SamplingResult shouldSample(Context context, TraceId traceId, String spanName, SpanKind spanKind, List<Attribute> spanAttributes, List<SpanLink> spanLinks)
//    `type` of `spanIsRemote` has changed.
//    Changing a parameter signature is a major change.

@@ line 4: package:opentelemetry/src/sdk/trace/sampling/parent_based_sampler.dart @@
class ParentBasedSampler implements Sampler
-     SamplingResult shouldSample(Context context, TraceId traceId, String spanName, SpanKind spanKind, bool spanIsRemote, List<Attribute> spanAttributes, List<SpanLink> spanLinks)
+     SamplingResult shouldSample(Context context, TraceId traceId, String spanName, SpanKind spanKind, List<Attribute> spanAttributes, List<SpanLink> spanLinks)
//    `type` of `spanIsRemote` has changed.
//    Changing a parameter signature is a major change.

@@ line 4: package:opentelemetry/src/sdk/trace/sampling/always_off_sampler.dart @@
class AlwaysOffSampler implements Sampler
-     SamplingResult shouldSample(Context context, TraceId traceId, String spanName, SpanKind spanKind, bool spanIsRemote, List<Attribute> spanAttributes, List<SpanLink> links)
+     SamplingResult shouldSample(Context context, TraceId traceId, String spanName, SpanKind spanKind, List<Attribute> spanAttributes, List<SpanLink> links)
//    `type` of `spanIsRemote` has changed.
//    Changing a parameter signature is a major change.

Showing results for aa24871

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.2
Browse public API.

[michaelyeager-wf]

@Workiva/release-management-p

[rmconsole-wf]

+1 from RM