Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O11Y-1770: Add required files to opentelemetry-dart repo for OSS #51

Merged
merged 3 commits into from
May 25, 2022

Conversation

keruitan-wk
Copy link
Contributor

@keruitan-wk keruitan-wk commented May 4, 2022

https://jira.atl.workiva.net/browse/O11Y-1770

In order to OSS opentelemetry-dart we need to add the following files in the repo:

  • Apache 2.0 license file
  • notice file
  • Ensure copyright headers are applied to all source files
  • Github workflows Dart CI for external contributors

examples for files: https://github.com/Workiva/w_transport

Context: https://wiki.atl.workiva.net/display/DEV/OSS+External+Publishing+Process

@rmconsole-wf
Copy link

rmconsole-wf commented May 4, 2022

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s):

Code Review(s): #51
Release Image Tags:

Reviewers: blakeroberts-wk, keruitan-wk

Additional Information

Watchlist Notifications: None
Pull Requests included in release:

	When this pull is merged I will add it to the following release:
	Current version: opentelemetry-dart 0.11.1
	Version after merge: opentelemetry-dart 0.11.1
	Release Ticket(s): O11Y-1851

	This pull is considered a release pull
	The options defined for this repo will be carried out


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Wednesday, May 25 04:18 PM CST

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@semveraudit-wf
Copy link

semveraudit-wf commented May 4, 2022

Public API Changes

No changes to the public API found for commit 51fdb28

Showing results for 51fdb28

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.2
Browse public API.

Last edited UTC May 25 at 19:43:26

blakeroberts-wk
blakeroberts-wk previously approved these changes May 9, 2022
@keruitan-wk
Copy link
Contributor Author

QA+1 Dart CI workflow is passing

@keruitan-wk
Copy link
Contributor Author

@Workiva/release-management-p

@rmconsole-wf
Copy link

@keruitan-wk I will not merge this because:

  • 'QA Review' is False

@keruitan-wk
Copy link
Contributor Author

QA+1

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit 1590cf0 into master May 25, 2022
@rm-astro-wf rm-astro-wf deleted the O11Y-1770 branch May 25, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants