Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O11Y-1804: Update Dart Dockerfile to use new Dart image #57

Merged
merged 1 commit into from
May 10, 2022
Merged

O11Y-1804: Update Dart Dockerfile to use new Dart image #57

merged 1 commit into from
May 10, 2022

Conversation

michaelyeager-wf
Copy link
Contributor

Notes

This PR updates our Dart build image from those hosted at https://hub.docker.com/r/google/dart, which are discontinued, to those hosted at https://hub.docker.com/_/dart and makes updates to facilitate differences between them.

The versions of Dart used have remained the same.

Reviewers

@Workiva/observability

@michaelyeager-wf michaelyeager-wf requested a review from a team as a code owner May 9, 2022 20:40
@rmconsole-wf
Copy link

rmconsole-wf commented May 9, 2022 •
edited by rm-astro-wf
Loading

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s):

Code Review(s): #57
Release Image Tags:

Reviewers: michaelyeager-wf, blakeroberts-wk

Additional Information

Watchlist Notifications: None
Pull Requests included in release:

	When this pull is merged I will add it to the following release:
	Current version: opentelemetry-dart 0.9.4
	Version after merge: opentelemetry-dart 0.9.4
	Release Ticket(s): O11Y-1811

	This pull is considered a release pull
	The options defined for this repo will be carried out

Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Tuesday, May 10 09:24 AM CST

michaelyeager-wf
michaelyeager-wf commented May 9, 2022
View reviewed changes
Dockerfile
WORKDIR /build

RUN apt update && apt install -y make protobuf-compiler wget
RUN apt update && apt install -y make protobuf-compiler gnupg wget
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wget requires gnupg, which is not installed by default on the updated image.

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

michaelyeager-wf
michaelyeager-wf commented May 9, 2022
View reviewed changes
Dockerfile
@@ -15,7 +15,8 @@ RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key
mv /usr/bin/google-chrome-stable /usr/bin/google-chrome && \
sed -i --follow-symlinks -e 's/\"\$HERE\/chrome\"/\"\$HERE\/chrome\" --no-sandbox/g' /usr/bin/google-chrome

RUN make init analyze test
RUN export PATH="$PATH":"$HOME/.pub-cache/bin" && \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protoc is installed to the user's pub cache, which is not in PATH on the updated image.

@semveraudit-wf
Copy link

Public API Changes

No changes to the public API found for commit 91ae500

Showing results for 91ae500

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.2
Browse public API.

@michaelyeager-wf
Copy link
Contributor Author

Build completes successfully on the new image.

QA +1

@michaelyeager-wf
Copy link
Contributor Author

@Workiva/release-management-p

rmconsole-wf
rmconsole-wf approved these changes May 10, 2022
View reviewed changes
Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit 2a1dc17 into Workiva:master May 10, 2022
@rm-astro-wf rm-astro-wf deleted the myeager-wf/O11Y-1804 branch May 10, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeroberts-wk blakeroberts-wk blakeroberts-wk approved these changes

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready semver: Patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michaelyeager-wf @rmconsole-wf @aviary-wf @semveraudit-wf @blakeroberts-wk @rm-astro-wf