-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
O11Y-992: OTEL Dart: Implement OTLP HTTP Reporter #6
Conversation
Merge Requirements Met ✅Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment. General InformationTicket(s): Code Review(s): #6 Reviewers: tylerrinnan-wf, blakeroberts-wk, tylersnavely-wf Additional InformationWatchlist Notifications: None
Note: This is a shortened report. Click here to view Rosie's full evaluation. |
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
resource: Resource(attributes: [ | ||
KeyValue( | ||
key: 'service.name', | ||
value: AnyValue(stringValue: spans[0].tracer.name)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than give a span the whole tracer, I think it makes sense to give the span resource
and instrumentationLibrary
attributes which can be serialized. This would be inline with the js version: https://github.com/open-telemetry/opentelemetry-js/blob/30733df5cbddb8bc60da5bc7a65f25a182f036d8/packages/opentelemetry-exporter-collector/src/transform.ts#L305-L324
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly so we don't expose the api tracer.startSpan().tracer.StartSpan()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! We should correct this once https://jira.atl.workiva.net/browse/O11Y-994 is completed. I believe that has some work to include Resources, so we can easily adjust afterward.
QA +1 |
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
This introduces the collector exporter.
An example setup would look like this:
Notes:
Because this requires generated protobuf code, I've added the protobuf definitions as a submodule, and made
make init
generate the files.