Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource Attribute for Deployment Environment #61

Conversation

michaelyeager-wf
Copy link
Contributor

Notes

This PR adds a ResourceAttribute key for the deployment environment.

Reviewers

@Workiva/observability

@rmconsole-wf
Copy link

rmconsole-wf commented Jun 3, 2022

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s): None found in title
Code Review(s): #61
Release Image Tags:

Reviewers: michaelyeager-wf, keruitan-wk

Additional Information

Watchlist Notifications: None
Pull Requests included in release:

	When this pull is merged I will add it to the following release:
	Current version: opentelemetry-dart 0.13.1
	Version after merge: opentelemetry-dart 0.14.0
	Release Ticket(s): O11Y-1870

	This pull is considered a release pull
	The options defined for this repo will be carried out


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Friday, June 03 02:52 PM CST

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@semveraudit-wf
Copy link

Public API Changes

Recommendation: ⚠️ Minor version bump

@@ line 5: package:opentelemetry/src/api/common/resource_attributes.dart @@
class ResourceAttributes
+     static String get deploymentEnvironment
//    Adding a field is a minor change.

Showing results for fb2388b

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.2
Browse public API.

@michaelyeager-wf
Copy link
Contributor Author

PR is for the addition of a string constant. Further testing not required.

QA +1

@michaelyeager-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit bac2b7e into Workiva:master Jun 3, 2022
@rmconsole7-wk rmconsole7-wk deleted the myeager-wf/add-deployment-environment-attribute branch June 3, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants