-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resource Attribute for Deployment Environment #61
Add Resource Attribute for Deployment Environment #61
Conversation
Merge Requirements Met ✅Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment. General InformationTicket(s): None found in title Reviewers: michaelyeager-wf, keruitan-wk Additional InformationWatchlist Notifications: None
Note: This is a shortened report. Click here to view Rosie's full evaluation. |
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Public API ChangesRecommendation: @@ line 5: package:opentelemetry/src/api/common/resource_attributes.dart @@
class ResourceAttributes
+ static String get deploymentEnvironment
// Adding a field is a minor change.
Showing results for fb2388b
|
PR is for the addition of a string constant. Further testing not required. QA +1 |
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Notes
This PR adds a ResourceAttribute key for the deployment environment.
Reviewers
@Workiva/observability