Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O11Y-2149: Resolve changelog warning for publishing to public pub server #68

Merged
merged 4 commits into from
Aug 18, 2022

Conversation

dustinlessard-wf
Copy link
Contributor

@dustinlessard-wf dustinlessard-wf commented Aug 17, 2022

Problem

When running "dart pub publish --dry-run":

Package validation found the following potential issues:

* 1 checked-in file is ignored by a `.gitignore`.
  Previous versions of Pub would include those in the published package.
  
  Consider adjusting your `.gitignore` files to not ignore those files, and if you do not wish to
  publish these files use `.pubignore`. See also dart.dev/go/pubignore
  
  Files that are checked in while gitignored:
  
  lib/src/sdk/proto/opentelemetry-proto/.vscode/settings.json
  
* Please add a `CHANGELOG.md` to your package. See https://dart.dev/tools/pub/publishing#important-files.Package has 3 warnings. 

Resolved issue 2. Issue 1 is related to the use of submodules and I was not able to find a solution to it.

Fixes #67

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@semveraudit-wf
Copy link

semveraudit-wf commented Aug 17, 2022

Public API Changes

No changes to the public API found for commit f04f9d3

Showing results for f04f9d3

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.2
Browse public API.

Last edited UTC Aug 17 at 19:33:02

@dustinlessard-wf dustinlessard-wf changed the title O11Y-2149: Resolve warnings for publishing to public pub server O11Y-2149: Resolve changelog warning for publishing to public pub server Aug 17, 2022
.pubignore Outdated
@@ -0,0 +1 @@
lib/src/sdk/proto/opentelemetry-proto/.vscode/settings.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling this file was accidentally committed to the repo. I have a feeling it was me. We should remove the file altogether

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked and it wasn't you. This is coming in via submodule: https://github.com/open-telemetry/opentelemetry-proto/tree/main/.vscode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh. cool. well, they should stop that

CHANGELOG.md Outdated
@@ -0,0 +1,3 @@
## [0.14.1]()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [0.14.1]()
## 0.14.1

@dustinlessard-wf
Copy link
Contributor Author

Ready for re-review.

@dustinlessard-wf
Copy link
Contributor Author

dustinlessard-wf commented Aug 17, 2022

QA +1 , published to the public pub server using these changes.

@dustinlessard-wf
Copy link
Contributor Author

@Workiva/release-management-p

@dustinlessard-wf
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit 5289eb0 into master Aug 18, 2022
@rmconsole3-wf rmconsole3-wf deleted the O11Y-2149 branch August 18, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pub publishing indicates warning related to missing changelog
8 participants