Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTL-1793 : Have over_react_codemod show deprecation message #288

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

chetansinghchoudhary-wk
Copy link
Contributor

Problem

  • When intl_codemod is ready to be used via dart_dev_workiva, we should show a deprecation message in the over_react_codemod:intl_migration version. It should point out it will not be used anymore and then link to the new dart_dev command versions.

AC:

  • over_react_codemod:intl_migration should show a deprecation message
  • The message should point out it won't be updated anymore, and point them to our dart_dev / dart_dev_workiva version.

Solution

  • Added a message saying it's deprecated and told users to use the dart_dev command instead and also updated the wiki link(FEF/intl). The link to the wiki will be updated once INTL-1792 done.

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf
Copy link
Member

QA+1 CI passes

@robbecker-wf
Copy link
Member

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit 0c235dd into master Apr 25, 2024
14 checks passed
@rmconsole5-wk rmconsole5-wk deleted the INTL-1793 branch April 25, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants