CPLAT-7393 Add logic to handle components with mixin(s) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
joebingham-wk
approved these changes
Sep 16, 2019
+ Add FIXME comment to components that have mixins when the no-partial-upgrades flag is false + Skips the upgrade for components that have mixins when the no-partial-upgrades flag is true + CPLAT-7393 # Conflicts: # lib/src/component2_suggestors/class_name_and_annotation_migrator.dart
aaronlademann-wf
force-pushed
the
CPLAT-7393_with-not-so-much
branch
from
f5094d1
to
4213258
Compare
rmconsole-wf
added
Merge Requirements Unmet
and removed
Merge Conflicts
Merge Requirements Met
labels
aaronlademann-wf
force-pushed
the
CPLAT-7393_with-not-so-much
branch
2 times, most recently
from
06bc63f
to
3816146
Compare
aaronlademann-wf
force-pushed
the
CPLAT-7393_with-not-so-much
branch
from
3816146
to
94d1228
Compare
kealjones-wk
approved these changes
Sep 17, 2019
| input: ''' | ||
| /// This is my current documentation comment. | ||
| /// | ||
| /// As you can see it has more than one line, which is pretty great! |
| render() {} | ||
| } | ||
| ''', | ||
| expectedOutput: ''' |
There was a problem hiding this comment.
#nit
you don't need to include expectedOutput if it is the same as the input
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
UIComponents with mixins could potentially be mixing in a class that implement component lifecycle methods that are unsupported inComponent2.Changes
--no-partial-upgradesflag isfalse, add a/// FIXMEcomment to the component that has one or more mixins.--no-partial-upgradesflag istrue, skips the upgrade for the component that has one or more mixins.Release Notes
Add logic to handle components with mixin(s) when upgrading to
UiComponent2.Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review: @greglittlefield-wf @kealjones-wk @sydneyjodon-wk @joebingham-wk
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: