Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-6563 Codemod to migrate consumer overlays to new APIs, fixing deprecations #58

Merged
merged 6 commits into from
Oct 1, 2019

Conversation

sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented Sep 25, 2019

Motivation

To aid in upgrading users, we should expose a codemod that migrates consumers.

Changes

  • Set up new executable react16_consumer_overlay_update
  • Add suggestor that, in component usages:
    • Replaces ..overlay = … with ..overlay2 = …
    • Replaces ..isOverlay = … with ..isOverlay2 = …
    • Removes ..useLegacyPositioning = …
  • Write tests

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
@kealjones-wk @aaronlademann-wf @greglittlefield-wf @joebingham-wk

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
      • CI passes
      • Run the React16 Consumer Overlays Update codemod on web_skin_dart and verify that the codemod updates overlay props based on the above criteria.
        • pub global run over_react_codemod:react16_consumer_overlay_update
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@@ -141,7 +141,6 @@ bool fullyUpgradableToComponent2(ClassDeclaration classNode) {
/// * Generic parameters on component class
/// * `@AbstractProps` in the same file
bool canBeExtendedFrom(ClassDeclaration classNode) {
var a = classNode.typeParameters;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Girlscoutin like a champ! 👍

@kealjones-wk
Copy link
Contributor

+10

@kealjones-wk
Copy link
Contributor

@Workiva/release-management-p

@rmconsole4-wk rmconsole4-wk merged commit bef425f into master Oct 1, 2019
@rmconsole4-wk rmconsole4-wk deleted the CPLAT-6563-migrate-consumer-overlays branch October 1, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants