RM-217585 FED-1716 Release react-dart 7.0.0 (null-safety) #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can't really be made null safe, and we always intended on removing it in the next major.
Simulated synthetic events will be missing some properties if they're not included in eventData, meaning the non-nullable typings on them are incorrect. As opposed to making everything nullable to account for that, we'll treat those simulated events the same way Mockito treats mock objects, and just require that any properties being accessed get stubbed in using the eventData argument.
versioning it
useRef without an argument is more common than with one, and this
approach improves that experience by:
1. not requiring consumers explicitly provide `null` and provide
a nullable type argument
2. not involving a new, versioned API that must be migrated to
Importantly, this fixes some callback ref typing issues after fixing unnecessary_lambdas lints
greglittlefield-wf
changed the title
This was referenced Nov 8, 2023
FED-1881 Fix regression in SyntheticEvent mock class type-checking
|
Skynet test results failed initially for this build but were approved by rob.becker |
robbecker-wf
approved these changes
Nov 10, 2023
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've been working on a 7.0.0 null-safe release, and it's time to merge it!
Changes
All commits through 440c5e3 have been reviewed in other PRs:
Leaving only commits later than 440c5e3 to be reviewed.
New changes in those commits include:
dartInteropStaticsas@internal(I had it in the changelog draft listed as a removal, but apparently it was never public in the first place)Testing