Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDN publish back temporarily #400

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

robbecker-wf
Copy link
Member

@robbecker-wf robbecker-wf commented Jun 7, 2024

Summary

We moved to Github Actions but need to fix some things internal to Workiva before being able to remove Dockerfile and skynet.yaml completely. This undoes those removals and drops older versions of Dart from CI.

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf robbecker-wf marked this pull request as ready for review June 7, 2024 18:20
Copy link
Collaborator

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

  • CDN asset looks correct
  • Skynet run successful

@robbecker-wf
Copy link
Member Author

@Workiva/release-management-p :letsroll:

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit 79f7a1c into master Jun 7, 2024
5 checks passed
@rmconsole4-wk rmconsole4-wk deleted the add_cdn_publish_back_temporarily branch June 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants