FEDX-126 FED-1719 Null Safety Migration

[sydneyjodon-wk]

Note: Merging is dependent on react-dart null safety migration completion. ✅

This null safety migration is almost complete. With the following remaining todos:

• Get CI passing
  • Remaining test failures are due to an attribute issue (see comment below)
• Do some consumer testing

QA Instructions

• CI passes
• Consumer tests pass:
  • https://github.com/Workiva/react_material_ui/pull/758
  • https://github.com/Workiva/xbrl-module/pull/5692 - the one test failure is expected because null is being passed in when it shouldn't be
  • https://github.com/Workiva/esg_ui/pull/2302
  • https://github.com/Workiva/graph_ui/pull/7284 (re-run after home releases)
  • https://github.com/Workiva/highcharts/pull/1167
  • https://github.com/Workiva/w_filing/pull/3903 - the five test failures are the same issue as xbrl-module with null being passed in when it shouldn't be

[aviary2-wf]

Security Insights

The items listed below may not capture all security relevant changes. Before providing a security review, be sure to review the entire PR for security impact.

(1) Security relevant changes were detected

Watched keyword innerHtml in lib/src/matchers/jest_dom/is_empty_dom_element.dart line(s) ['70'] added

Action Items

• Obtain a security review; reviewer should pay special attention to insights listed above
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[sydneyjodon-wk]

@aaronlademann-wf I think I addressed all your comments - I went back through and checked a lot of typing with the JS typing

[aaronlademann-wf]

@sydneyjodon-wk looks like the highcharts consumer PR has a merge conflict, and the w_filing PR has failing tests.

All the others are passing, so I "checked them off" in your description.

So close!

[aaronlademann-wf]

QA +1

• CI is passing
• All consumer tests listed in the description are passing

[aaronlademann-wf]

Semver +1

• This is expected to be a major release
• Rosie's version after merge is correct as 3.0.0

[greglittlefield-wf]

Just found a few things, with a good chunk of them just being test cleanliness.

[greglittlefield-wf]

semver +1

[kealjones-wk]

Security +1

• Watched keyword innerHtml in lib/src/matchers/jest_dom/is_empty_dom_element.dart line(s) ['70'] added

  • This is safe usage as it is not setting the innerHtml and it is also only doing boolean check to see if that text is empty and doing nothing else with it.

  For future reference you could instead use .textContent and it will return the same content without tripping up aviary.

[sydneyjodon-wk]

@Workiva/release-management-p

[aaronlademann-wf]

QA +1 refresh

• CI Passing
• Relevant Consumer Tests Passing

[rmconsole-wf]

+1 from RM