FEA-2863: Expose debug transport URL when possible #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsThe items listed below may not capture all security relevant changes. Before providing a security review, be sure to review the entire PR for security impact. (1) Security relevant changes were detectedlib/sockjs.js modifiedAction Items
Questions or Comments? Reach out on Slack: #support-infosec. |
evanweible-wf
commented
Nov 1, 2023
| @@ -29,4 +29,4 @@ echo.on('connection', function(conn) { | |||
|
|
|||
| var server = http.createServer(); | |||
| echo.installHandlers(server, {prefix:'/echo'}); | |||
| server.listen(9999, '0.0.0.0'); | |||
| server.listen(9009, '0.0.0.0'); | |||
There was a problem hiding this comment.
The dart analysis server's diagnostics run on this port, so I changed it.
evanweible-wf
commented
Nov 1, 2023
lib/sockjs.js
Outdated
There was a problem hiding this comment.
This gets auto-collapsed by Github but it's the change that should be reviewed :)
yuanmwang-wf
previously approved these changes
Nov 1, 2023
corwinsheahan-wf
previously approved these changes
Nov 1, 2023
evanweible-wf
dismissed stale reviews from corwinsheahan-wf and yuanmwang-wf
via
c3e4e6d
corwinsheahan-wf
approved these changes
Nov 2, 2023
|
security +1
|
rmconsole2-wf
changed the title
bender-wk
changed the title
|
QA +1
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For debugging purposes, it would be helpful to have access to the full URL used by the underlying SockJS transport (the one that includes the selected protocol and session ID). This is currently not exposed publicly anywhere.
Changes
sockjs.jsfile wrapped by this library to settransportUrlon theSockJSclient instance.SockJSOpenEventDart type to include adebugUrlfield that gets set to the newtransportUrlfield