-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unblock Analyzer 1 #26
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
pub_semver: ^2.1.2 | ||
shelf: ^1.2.0 | ||
shelf_proxy: ^1.0.0 | ||
stack_trace: ^1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regular dependency upgrades are safe because webdev_proxy is installed globally
@@ -61,7 +61,7 @@ void main() { | |||
); | |||
|
|||
final response = | |||
await http.get('http://localhost:${proxy.port}/index.dart'); | |||
await http.get(Uri.parse('http://localhost:${proxy.port}/index.dart')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address the breaking changes in http 0.13
@@ -15,7 +15,7 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
sdk: [ stable, 2.13.4, dev ] | |||
sdk: [ stable, 2.13.4 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the dev branch of Dart since that's now 3.0 dev and it immediately fails due to the SDK constraints of this package.
QA+1 CI Passes and tested serving some example apps @Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Summary
Frontend Frameworks is updating dependencies! More details at
https://wiki.atl.workiva.net/display/CP/Dependency+Upgrades
Changes
Process
Someone from FEF will prepare this PR, fix any issues and move
it out of draft state when it's ready.
markdown 5 and xml 5 have been tested in w_table and w_filing
but teams should do manual testing of processes that require
xml or markdown. (Once the PR is ready)
For all the other updates, a resolving pub get to analyzer 1+ and
passing CI should be good.
For more info, reach out to
#support-frontend-architecture
on Slack.Created by Sourcegraph batch change
Workiva/unblock_analyzer1
.