Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock Analyzer 1 #26

Merged
merged 6 commits into from
Dec 22, 2022
Merged

Unblock Analyzer 1 #26

merged 6 commits into from
Dec 22, 2022

Conversation

sourcegraph-wk
Copy link

Summary

Frontend Frameworks is updating dependencies! More details at
https://wiki.atl.workiva.net/display/CP/Dependency+Upgrades

Changes

  # dev dependencies, raise min
  pubspec_codemod raise-min w_common_tools 2.0.0 --recursive
  pubspec_codemod raise-min dart_dev_workiva 2.0.0 --recursive
  pubspec_codemod raise-min mockito 5.0.0 --recursive
  pubspec_codemod raise-min glob 2.0.0 --recursive
  pubspec_codemod raise-min puppeteer 2.0.0 --recursive
  pubspec_codemod raise-min puppeteer_platform 1.3.0 --recursive
  
  # dependencies, raise min
  pubspec_codemod raise-min http 0.13.0 --recursive
  pubspec_codemod raise-min dio 4.0.0 --recursive

  # dependencies, raise max
  pubspec_codemod raise-max intl 0.18.0 --recursive
  pubspec_codemod raise-max archive 4.0.0 --recursive
  pubspec_codemod raise-max yaml 4.0.0 --recursive
  pubspec_codemod raise-max markdown 6.0.0 --recursive
  pubspec_codemod raise-max xml 6.0.0 --recursive
  pubspec_codemod remove tuneup

Process

Someone from FEF will prepare this PR, fix any issues and move
it out of draft state when it's ready.

markdown 5 and xml 5 have been tested in w_table and w_filing
but teams should do manual testing of processes that require
xml or markdown. (Once the PR is ready)
For all the other updates, a resolving pub get to analyzer 1+ and
passing CI should be good.

For more info, reach out to #support-frontend-architecture on Slack.

Created by Sourcegraph batch change Workiva/unblock_analyzer1.

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

pub_semver: ^2.1.2
shelf: ^1.2.0
shelf_proxy: ^1.0.0
stack_trace: ^1.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The regular dependency upgrades are safe because webdev_proxy is installed globally

@@ -61,7 +61,7 @@ void main() {
);

final response =
await http.get('http://localhost:${proxy.port}/index.dart');
await http.get(Uri.parse('http://localhost:${proxy.port}/index.dart'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address the breaking changes in http 0.13

@robbecker-wf robbecker-wf marked this pull request as ready for review December 22, 2022 16:09
@@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [ stable, 2.13.4, dev ]
sdk: [ stable, 2.13.4 ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the dev branch of Dart since that's now 3.0 dev and it immediately fails due to the SDK constraints of this package.

@robbecker-wf
Copy link
Member

QA+1 CI Passes and tested serving some example apps @Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit 341c2b7 into master Dec 22, 2022
@rmconsole7-wk rmconsole7-wk deleted the batch/fedx/unblock_analyzer1 branch December 22, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants