Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute slope with scipy, avoiding the use of richdem #138

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Conversation

kvantricht
Copy link
Contributor

No description provided.

@kvantricht kvantricht changed the title resample DEM with bilinear interpolator Compute slope with scipy, avoiding the use of richdem Aug 29, 2024
@kvantricht
Copy link
Contributor Author

@GriffinBabe this version now no longer needs richdem. You'll see _compute_slope is now much longer so not sure if it still fits in FeatureExtractor. Please have a look. Also, once global slope is available as collection, we need to implement a check that only computes slope if the band is not available yet (should be straightforward, can do this later in new branch).

One comment in the code now: correct slope computation needs to know the resolution. Set it at 10m now. Is it safe to assume this will always be the case? Or can we check it from the array?

@GriffinBabe GriffinBabe merged commit 231eb18 into main Aug 29, 2024
2 checks passed
@GriffinBabe GriffinBabe deleted the fix-slope branch August 29, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants