Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaned notebooks for demo #190

Merged
merged 7 commits into from
Oct 16, 2024
Merged

cleaned notebooks for demo #190

merged 7 commits into from
Oct 16, 2024

Conversation

jdegerickx
Copy link
Contributor

  • cleaned all outputs
  • harmonized explanations across notebooks
  • altered filenames
  • fixed table of contents
  • added figure on cropland sample density

kvantricht
kvantricht reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@kvantricht kvantricht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments put in one notebook but valid for the others too. Besides, the postprocessing parameter section seems overkill, especially if we have it everywhere like that.

notebooks/worldcereal_v1_demo_custom_cropland.ipynb Show resolved Hide resolved
notebooks/worldcereal_v1_demo_custom_cropland.ipynb Outdated Show resolved Hide resolved
@jdegerickx
Copy link
Contributor Author

  • added some more explanation on area limits for ui_map
  • ensured user can set custom model name and folder name for each individual model run using new get_input() function

@kvantricht kvantricht self-requested a review October 16, 2024 07:45
@kvantricht kvantricht merged commit 2b49731 into main Oct 16, 2024
4 checks passed
@kvantricht kvantricht deleted the clean-notebooks branch October 16, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvantricht kvantricht kvantricht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdegerickx @kvantricht