Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Synthetic press functionality depending on isChecked state update #270

Closed
wants to merge 1 commit into from

Conversation

kimava
Copy link

@kimava kimava commented May 20, 2023

Makes checked state respond to isChecked prop changes so that you don't need to use disableBuiltInState and useRef and can easily toggle checkbox when you need synthetic press functionality.

@WrathChaos WrathChaos self-requested a review May 20, 2023 12:35
@WrathChaos WrathChaos self-assigned this May 20, 2023
@kimava
Copy link
Author

kimava commented Jun 13, 2023

Hi! Just wanted to check in on this pull request. I understand you might be busy, but I was wondering if you had a chance to review it or if there's anything I can do to help move it forward.

@WrathChaos
Copy link
Owner

Hey @kimava
Totally my bad, I am going to take a look at this today. Apologize 🙏

@WrathChaos
Copy link
Owner

WrathChaos commented Jun 19, 2023

Hey @kimava

I am really sorry for late response to take a look at this. It looks really great, however if this can replace the disableBuiltInState can we also remove the disableBuiltInState logics so it will be an awesome improvement :)

@WrathChaos
Copy link
Owner

WrathChaos commented Apr 6, 2024

Hello @kimava

It's been awhile but finally I found some time and managed to publish version 4. Thank you so much for your contribution, we got rid of disableBuiltInState prop :)

Please take a look at the new version when you have time :)

Version 4.0.0 🥳

@WrathChaos WrathChaos closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants