First pass at using puffin to display the query results #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry for the delay in review. Hoping to give this a spin by the end of the week! |
Wumpf
requested changes
Sep 21, 2024
There was a problem hiding this comment.
good start, I think this is already plenty useful. Even if we figure out how to combine this into a single puffin connection, this mode of operation can still be quite useful imho!
Some docs are missing and I believe the frame processing should be slightly different. Details see comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a first pass at a way to display the
GpuTimerQueryResultin puffin. This only depends on the basepuffincrate, notpuffin_eguiorpuffin_http. I addedpuffin_httpas a dev dependency to the example since it's not as invasive of a change as usingegui.This current approach assumes you use a different
puffin::GlobalProfilerfor wgpu than for CPU threads. I'm not the biggest fan of this approach, and I'd prefer to pretend that the WGPU Queue is just like any other CPU thread, and show them all in the same profiler window. However, the fact that we may need to wait several frames for timer results from the GPU makes this difficult.