Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Task 1: Platform Switch for Gitee and Github Rankings #120

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

iamSmallY
Copy link

@iamSmallY iamSmallY commented Jul 8, 2024

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

Added a selector to select different data sources such as GitHub or Gitee.

Checklist

Others

Currently the front-end can only fetch data from Github, so the data fetching part has not been modified for the time being, and only a selector has been added.

@andyhuang18
Copy link
Collaborator

Refer to contribution. You should run npm run prettier to unify the code format after completing the task. This problem caused the workflow to fail. Please modify and commit the code in time.

@andyhuang18
Copy link
Collaborator

When using select, you can consider setting its default width, otherwise the problem shown in the following picture will occur.

image

In addition, there is a tip in the antd official document that "Utilizing Radio is recommended when there are fewer total options (less than 5)."

Since there are only three platforms to choose from, github, gitee and all, I recommend using Radio to implement this function. Please feel free to share your ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OSS101] Task 1: Platform Switch for Gitee and Github Rankings
4 participants