Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency express to v4.19.2 [SECURITY] #1614

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 26, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 4.18.3 -> 4.19.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with [email protected], we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location


Release Notes

expressjs/express (express)

v4.19.2

Compare Source

==========

  • Improved fix for open redirect allow list bypass

v4.19.1

Compare Source

==========

  • Allow passing non-strings to res.location with new encoding handling checks

v4.19.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Contributor Author

renovate bot commented Mar 26, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: pnpm-lock.yaml
Scope: all 21 workspace projects
Progress: resolved 1, reused 0, downloaded 0, added 0
Progress: resolved 36, reused 0, downloaded 31, added 0
.                                        |  WARN  deprecated @babel/[email protected]
Progress: resolved 85, reused 0, downloaded 80, added 0
Progress: resolved 98, reused 0, downloaded 93, added 0
Progress: resolved 99, reused 0, downloaded 94, added 0
Progress: resolved 117, reused 0, downloaded 112, added 0
Progress: resolved 134, reused 0, downloaded 129, added 0
Progress: resolved 144, reused 0, downloaded 139, added 0
Progress: resolved 153, reused 0, downloaded 148, added 0
Progress: resolved 153, reused 0, downloaded 149, added 0
Progress: resolved 172, reused 0, downloaded 167, added 0
Packages are hard linked from the content-addressable store to the virtual store.
  Content-addressable store is at: /home/ubuntu/.local/share/pnpm/store/v3
  Virtual store is at:             node_modules/.pnpm
 WARN  The git-hosted package fetched from "https://codeload.github.com/watson/ci-info/tar.gz/3e1488e98680f1f776785fe8708a157b7f00e568" has to be built but the build scripts were ignored.
packages/next                            |  WARN  deprecated @babel/[email protected]
packages/next                            |  WARN  deprecated @babel/[email protected]
packages/next                            |  WARN  deprecated @babel/[email protected]
Progress: resolved 213, reused 0, downloaded 208, added 0
Progress: resolved 216, reused 0, downloaded 211, added 0
packages/next                            |  WARN  deprecated @types/[email protected]
packages/next                            |  WARN  deprecated @types/[email protected]
Progress: resolved 256, reused 0, downloaded 251, added 0
/tmp/renovate/repos/github/X-oss-byte/Nextjs/packages/third-parties:
 ERR_PNPM_FETCH_404  GET https://registry.npmjs.org/next/-/next-13.5.0.tgz: Not Found - 404

This error happened while installing a direct dependency of /tmp/renovate/repos/github/X-oss-byte/Nextjs/packages/third-parties

No authorization header was set for the request.

Copy link

stackblitz bot commented Mar 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Mar 26, 2024

⚠️ No Changeset found

Latest commit: 6809cda

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kodiakhq kodiakhq bot merged commit 348d420 into canary Mar 26, 2024
1 of 2 checks passed
@kodiakhq kodiakhq bot deleted the renovate/npm-express-vulnerability branch March 26, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants