Fixbug #11 and add a new option --json
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpaper
changed the title
--json--json
X140Yu
requested changes
Oct 31, 2019
Comment on lines
43
to
+44
| else | ||
| pp result | ||
| if @to_output_json |
|
|
||
| def final_path | ||
| d = File.join(Dir.tmpdir, 'pod') | ||
| if not Dir.exist?(d) |
Comment on lines
+69
to
+71
| f = File.open(template_path) | ||
| template = ERB.new(f.read) | ||
| f.close |
There was a problem hiding this comment.
直接用 File.read 就不需要手动 open, close 了
| f = File.open(template_path) | ||
| template = ERB.new(f.read) | ||
| f.close | ||
| return template.result(binding) |
| @@ -51,14 +46,16 @@ | |||
| function pageDidLoad() { | |||
| loadJSON('index.json', response => { | |||
| var actual_JSON = JSON.parse(response); | |||
There was a problem hiding this comment.
帮忙把这个文件里所有的 var 也一起改掉吧，当年年少不知事 =，=
| def write_d3js_to_file(path) | ||
| json = 'var dependencies = ' + to_d3js_json | ||
| File.write(path, json) | ||
| return json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixbug New Visual ouput feature not working on Chrome and Safari #11 : use erb template to generate the HTML file and feed data into it as embedded JavaScript
修复bug New Visual ouput feature not working on Chrome and Safari #11 : JavaScript跨域问题。
使用Ruby erb模板生成HTML文件，并将数据以JSON格式插入；在HTML中被解释为JS代码，避免了跨域请求数据。
output in JSON format by adding a option
--json增加一个选项
--json，输出格式为 JSON