Fix test_sal_on_coco_dets failure being masked #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencrowell
force-pushed
the
dev/fix-failure-masking
branch
2 times, most recently
from
97185b8
to
d3637d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 99.87% 99.87%
=======================================
Files 57 57
Lines 2330 2339 +9
=======================================
+ Hits 2327 2336 +9
Misses 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@stephencrowell Looks like you could probably register your GPG key with GitHub to get "verified" commits. |
Purg
reviewed
Feb 17, 2024
stephencrowell
force-pushed
the
dev/fix-failure-masking
branch
from
d3637d1
to
e4218d6
Compare
brianhhu
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
LGTM, thanks!
EDIT: @stephencrowell Can you fix the indent issue identified by the linter?
./tests/utils/test_sal_on_coco_dets.py:59:23: E128 continuation line under-indented for visual indent
./tests/utils/test_sal_on_coco_dets.py:82:23: E128 continuation line under-indented for visual indent
e4218d6
to
756a55f
Compare
|
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests encapsulated in tests/utils/test_sal_on_coco_dets.py are displaying a "PASS" in pytest's output, but actually raising an exception under the hood and yielding a non-zero return code. The test case was incorrect (including a
detwith noscoreorpredvalue) and did not check the return code. This change fixes the test case and fixes the non-zero return code