-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to hyper/http 1.0 #492
Comments
Thank you for your issue!
Yeah I tried upgrading other crates I maintain to 1.0.0 as a test, but this upgrade has been pretty painful in my experience, so I haven't made it a priority. I am able to help review the changes. I wonder if it's worth while to make a separate branch from it, so that we can continously make PRs for it, rather than require that someone migrate everything. |
Also worth linking this, which it took me a bit to find: https://hyper.rs/guides/1/upgrading/ |
Currently blocked on XAMPPRocky/octocrab#492
Now that version 1.0 of the hyper and http* crates are out, octocrab should probably follow suit. Unfortunately, it's a decently heavy lift, especially due to
Body
changing from a concrete type to a trait (hyperium/hyper#2345). I took a stab at it, but quickly got lost in a sea of<B: Body>
s, and figured I'd leave it to those who know the library best.A few bits I did pick up that may come in handy for someone wanting to take this on:
body::to_bytes(body).await?
becomesbody.collect().await?.to_bytes()
viahttp_body_util::BodyExt
Body
becomesBoxBody<hyper::body::Bytes, hyper::Error>
viahttp_body_util::combinators::BoxBody
if you want to keep it fully type-erased like it is today.Connector
trait (or rather, they're relegated tohyper_util::client::legacy
). Instead, there is nowhyper::client::conn::http1::Connection
.Also note that this will obviate:
which can probably all be closed in favor of this tracking issue.
The text was updated successfully, but these errors were encountered: