Strax interface #19
Strax interface #19
Conversation
This is should be there
…o strax_interface
…o strax_interface
| if root_dir.classname_of('events') == 'TTree': | ||
| ttree = root_dir['events'] | ||
| n_simulated_events = root_dir['nEVENTS'].members['fVal'] |
There was a problem hiding this comment.
Just a reminder that, for this option (MC newer than 4.0.0), we can here fetch the LXe level and pass it to the geometry config, to define properly the gas phase. I will get to it.
…o strax_interface
|
@WenzDaniel Does the output |
It was one of the instructions required by wfsim but (re)moved in this PR: XENONnT/WFSim#103 |
There was a problem hiding this comment.
I pushed a few fixes and looks good from my side now. I ran the last tests on the two G4 output files /dali/lgrandi/xenonnt/simulations/testing_epix_wfsim/tpc*cryoneutrons_200.root and paid attention to how the time shifts and max_delay cuts are applied for the three posible SourceRate args (-1, 0, >0). @HenningSE @WenzDaniel Give it a quick try for the file tpc_and_nveto_cryoneutrons_200.root and notice how the events with G4 id 134 and 185 behave. Everything seems correct, but these are just examples on how chunking and merging multiple full-chain outputs can become tricky.
We can discuss in the future if we want to remove the CutOnEventid flag and make things a bit simpler, but for the moment it does the job and such arguments won't be queried in full-chain runs.
@WenzDaniel Confirmed privately that he prefers to address the fix for massive ROOT files in a separate PR, as this will also require input from the WFSim experts (@petergaemers, @zhut19).
What is the problem / what does the code in this PR do
In this PR we add the possibility to return instructions without any time offsets.
Not yet included: