Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing return to stop plugin in case of empty input #216

Merged
merged 3 commits into from
May 16, 2024

Conversation

HenningSE
Copy link
Collaborator

@HenningSE HenningSE commented May 7, 2024

What does the code in this PR do / what does it improve?

This PR fixes a problem with empty input chunks to the PMTResponseAndDAQ plugin. Before this fix, the iteration for empty chunks was not properly stoped leading to data not continuous problems.

Can you briefly describe how it works?

I added the missing return to the empty input case of the PMTResponseAndDAQ plugin.

Please include the following if applicable:

  • Bump plugin version(s)
  • Tests to check the (new) code is working as desired.

@HenningSE HenningSE marked this pull request as ready for review May 7, 2024 07:02
@coveralls
Copy link

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 9107702936

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 71.482%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fuse/plugins/pmt_and_daq/pmt_response_and_daq.py 1 2 50.0%
Totals Coverage Status
Change from base Build 9107691937: -0.02%
Covered Lines: 2108
Relevant Lines: 2949

💛 - Coveralls

@HenningSE HenningSE merged commit a9d9d89 into main May 16, 2024
4 checks passed
@HenningSE HenningSE deleted the early_exit_PMTResponseAndDAQ branch May 16, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants